Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move physical allocation namespace out of virtual_ and up into memory #485

Closed
eyalroz opened this issue Mar 31, 2023 · 0 comments
Closed

Move physical allocation namespace out of virtual_ and up into memory #485

eyalroz opened this issue Mar 31, 2023 · 0 comments
Assignees
@eyalroz
Labels
resolved-on-development task

Comments

@eyalroz
Copy link
Owner

eyalroz commented Mar 31, 2023

The cuda::memory::virtual_::physical_allocation namespace contains definitions which are actually relevant to non-virtual-memory-related API calls - namely, memory pools. In preparation for adding support for those, let's bring this namespace out of the virtual_ sub-namespace.
@eyalroz eyalroz added the task label Mar 31, 2023
@eyalroz eyalroz self-assigned this Mar 31, 2023
eyalroz added a commit that referenced this issue Mar 31, 2023
@eyalroz
Fixes #485: physical_allocation now no longer a sub-namespace of `m…
16e67c2 
…emory::virtual_`
eyalroz added a commit that referenced this issue Mar 31, 2023
@eyalroz
Fixes #485: physical_allocation now no longer a sub-namespace of `m…
1a734da 
…emory::virtual_`
eyalroz added a commit that referenced this issue Apr 5, 2023
@eyalroz
Fixes #485: physical_allocation now no longer a sub-namespace of `m…
e597315 
…emory::virtual_`

* Moved some of the `physical_allocation` constructs up into `cuda::memory::` and others into `cuda::memory::physical_allocation`
* Renamed `access_mode_t` -> `access_permissions_t`
* Beefed up the `access_permission_t` class with some static methods and an enum of constants outside the class
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@eyalroz eyalroz

Labels
resolved-on-development task
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@eyalroz