Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

program_t::add_registered_globals should be able to take a container of any string-like type #529

Closed
eyalroz opened this issue Jun 10, 2023 · 1 comment

Comments

@eyalroz
Copy link
Owner

eyalroz commented Jun 10, 2023

In cuda::rtc::program_t, we currently have a:

add_registered_globals(Container&& globals_to_register);

member. The signature is file, but - it currently only works if the elements are const char*, not std::string nor any kind of string view.

@eyalroz eyalroz added the bug label Jun 10, 2023
@eyalroz eyalroz self-assigned this Jun 10, 2023
@eyalroz
Copy link
Owner Author

eyalroz commented Jun 10, 2023

... but we can't accept an rvalue reference to a container with non-const-char* . Also, we don't know about string_view's since we're in C++11.

eyalroz added a commit that referenced this issue Jun 10, 2023
…ake an lvalue-ref container of std::string's, plus comment and documentation tweaks.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant