Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unused / irrelevant functions in the launch config builder #561

Closed
eyalroz opened this issue Dec 24, 2023 · 0 comments
Closed

Unused / irrelevant functions in the launch config builder #561

eyalroz opened this issue Dec 24, 2023 · 0 comments

Comments

@eyalroz
Copy link
Owner

eyalroz commented Dec 24, 2023

We have a static function named cuda::grid::detail_::validate_all_dimension_compatibility in the launch config builder class' header file - and we don't use it anywhere. Looking more closely, there is a somewhat-related function, launch_config_builder_t::resolve_dimensions() - which sets the overall dimensions based on the grid and block dims; and that's something we don't even need to do.

Now, within the get_composite_dimension() method, it would be appropriate to perform this validation - so that we don't arbitrarily choose to abide by two of the three specified dimensions, ignoring the third; and that current doesn't happen. Also, since that's the only place the validation is relevant - we can probably let go of the whole function.

@eyalroz eyalroz self-assigned this Dec 24, 2023
eyalroz added a commit that referenced this issue Dec 24, 2023
* Dropped the unused static function `validate_all_dimension_compatibility`
* Added that validation when obtaining the composite block and grid dimensions
* Removed the `resolve_dimensions()` method - it's not useful (and not used anywhere else)
@eyalroz eyalroz closed this as completed in e3bd45f Jan 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant