Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use the launch config builder in more examples #578

Closed
eyalroz opened this issue Jan 29, 2024 · 0 comments
Closed

Use the launch config builder in more examples #578

eyalroz opened this issue Jan 29, 2024 · 0 comments
Assignees
@eyalroz
Labels
resolved-on-development task

Comments

@eyalroz
Copy link
Owner

eyalroz commented Jan 29, 2024

The launch config builder (#311 ) is awesome. Let's use it more! There are lots of examples which do this work themselves rather than just availing themselves of the builder.
@eyalroz eyalroz added the task label Jan 29, 2024
@eyalroz eyalroz self-assigned this Jan 29, 2024
eyalroz added a commit that referenced this issue Jan 29, 2024
@eyalroz
Fixes #578: Leaning more into the use of the launch config builder.
0e94573 
* Dropped `make_launch_config()`; you now either construct a `launch_configuration_t`, or use a launch config builder.
* All examples which were using `make_launch_config()` now use either simple construction of a builder.
eyalroz added a commit that referenced this issue Jan 29, 2024
@eyalroz
Fixes #578: Leaning more into the use of the launch config builder.
53e7437 
* Dropped `make_launch_config()`; you now either construct a `launch_configuration_t`, or use a launch config builder.
* All examples which were using `make_launch_config()` now use either simple construction of a builder.
eyalroz added a commit that referenced this issue Jan 29, 2024
@eyalroz
Fixes #578: Leaning more into the use of the launch config builder.
9f56b88 
* Dropped `make_launch_config()`; you now either construct a `launch_configuration_t`, or use a launch config builder.
* All examples which were using `make_launch_config()` now use either simple construction of a builder.
eyalroz added a commit that referenced this issue Feb 29, 2024
@eyalroz
Fixes #578: Leaning more into the use of the launch config builder.
2b6b953 
* Dropped `make_launch_config()`; you now either construct a `launch_configuration_t`, or use a launch config builder.
* All examples which were using `make_launch_config()` now use either simple construction of a builder.
@eyalroz eyalroz closed this as completed in f274fea Mar 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@eyalroz eyalroz

Labels
resolved-on-development task
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@eyalroz