Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hide "flags" from the interface of devices and contexts #637

Closed
eyalroz opened this issue Apr 12, 2024 · 0 comments
Closed

Hide "flags" from the interface of devices and contexts #637

eyalroz opened this issue Apr 12, 2024 · 0 comments
Assignees
@eyalroz
Labels
resolved-on-development task

Comments

@eyalroz
Copy link
Owner

eyalroz commented Apr 12, 2024

Flags are an implementation detail. Options, attributes, features - are legitimate. So, let's hide things like flags types, set_flags(), get_flags() and such - and keep them in detail_ namespaces only.
@eyalroz eyalroz added the task label Apr 12, 2024
@eyalroz eyalroz self-assigned this Apr 12, 2024
eyalroz added a commit that referenced this issue Apr 23, 2024
@eyalroz
Fixes #637: Hide the flag-related members from the public interface o…
4cbf042 
…f the device and context classes
eyalroz added a commit that referenced this issue Apr 29, 2024
@eyalroz
Fixes #637: Hide the flag-related members from the public interface o…
55bd71d 
…f the device and context classes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@eyalroz eyalroz

Labels
resolved-on-development task
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@eyalroz