Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Align the logic of context_t::create_module() with context::module::create() #654

Closed
eyalroz opened this issue Jun 15, 2024 · 0 comments
Closed

Align the logic of context_t::create_module() with context::module::create() #654

eyalroz opened this issue Jun 15, 2024 · 0 comments
Assignees
@eyalroz
Labels
bug resolved-on-development task

Comments

@eyalroz
Copy link
Owner

eyalroz commented Jun 15, 2024

context_t::create_module() does not seem to accept the same inputs as context::module::create(), for example: creating a module from and std::string. Their logic must be out of alignment... let's align it.
@eyalroz eyalroz self-assigned this Jun 15, 2024
@eyalroz eyalroz changed the title Align context_t::create_module() with context::module::create() Align the logic of context_t::create_module() with context::module::create() Jun 15, 2024
eyalroz added a commit that referenced this issue Jun 17, 2024
@eyalroz
Fixes #654 context_t::create_module() will now indeed act like `mod…
6089dee 
…ule::create()`
@eyalroz eyalroz closed this as completed in 58d5b31 Aug 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@eyalroz eyalroz

Labels
bug resolved-on-development task
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@eyalroz