Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Default to capturing on CUDA streams using the global capture mode #656

Closed
eyalroz opened this issue Jun 21, 2024 · 0 comments
Closed

Default to capturing on CUDA streams using the global capture mode #656

eyalroz opened this issue Jun 21, 2024 · 0 comments
Assignees
@eyalroz
Labels
resolved-on-development task

Comments

@eyalroz
Copy link
Owner

eyalroz commented Jun 21, 2024

NVIDIA says that cuda::stream::capture::mode_t::global is the default capture mode. So, let's make it our default as well, when a capture mode is not specified.
@eyalroz eyalroz added the task label Jun 21, 2024
@eyalroz eyalroz self-assigned this Jun 21, 2024
eyalroz added a commit that referenced this issue Jun 21, 2024
@eyalroz
Fixes #656, fixes #656: Stream capture functionality work:
cf1f1df 
* Now offering global capture mode as a default (so the user doesn't need to always specify it explicitly)
* Can now start and stop capturing using stand-alone functions in addition to stream_t methods.
eyalroz added a commit that referenced this issue Jun 21, 2024
@eyalroz
Fixes #656, fixes #656: Stream capture functionality work:
4156e9c 
* Now offering global capture mode as a default (so the user doesn't need to always specify it explicitly)
* Can now start and stop capturing using stand-alone functions in addition to stream_t methods
* Also marked `cuda::stream::capture::state()` as `inline`, although it  may not have needed it
@eyalroz eyalroz closed this as completed in 20e0514 Aug 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@eyalroz eyalroz

Labels
resolved-on-development task
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@eyalroz