Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test_suite does not respect the CMake configuration options #111

Closed
eyalroz opened this issue Feb 4, 2022 · 0 comments
Closed

test_suite does not respect the CMake configuration options #111

eyalroz opened this issue Feb 4, 2022 · 0 comments
Assignees
@eyalroz
Labels
resolved-on-develop A changeset fixing this issue has been commiutted to the development branch task testing Only relevant to the testing programs rather than the main code itself

Comments

@eyalroz
Copy link
Owner

eyalroz commented Feb 4, 2022

At the moment, our test suite ignores the CMake options we've set for the library itself - as it doesn't use the compiled library, nor does it include printf_config.h. We need to do one of those two things.
@eyalroz eyalroz added task testing Only relevant to the testing programs rather than the main code itself labels Feb 4, 2022
@eyalroz eyalroz self-assigned this Feb 4, 2022
@eyalroz eyalroz mentioned this issue Feb 4, 2022
Closed
eyalroz added a commit that referenced this issue Feb 4, 2022
@eyalroz
Fixes #111, #112: test suite now includes printf_config.h before `p…
9f48faf 
…rintf.c`; and separated cases of what's expected to be printed based on the value of `PRINTF_MAX_INTEGRAL_DIGITS_FOR_DECIMAL`.
@eyalroz eyalroz added the resolved-on-develop A changeset fixing this issue has been commiutted to the development branch label Feb 4, 2022
eyalroz added a commit that referenced this issue Feb 7, 2022
@eyalroz
Fixes #111, #112: test suite now includes printf_config.h before `p…
6a65d4d 
…rintf.c`; and separated cases of what's expected to be printed based on the value of `PRINTF_MAX_INTEGRAL_DIGITS_FOR_DECIMAL`.
eyalroz added a commit that referenced this issue Feb 10, 2022
@eyalroz
Fixes #111, #112: test suite now includes printf_config.h before `p…
bb09d22 
…rintf.c`; and separated cases of what's expected to be printed based on the value of `PRINTF_MAX_INTEGRAL_DIGITS_FOR_DECIMAL`.
eyalroz added a commit that referenced this issue Feb 11, 2022
@eyalroz
Fixes #111, #112: test suite now includes printf_config.h before `p…
5568a82 
…rintf.c`; and separated cases of what's expected to be printed based on the value of `PRINTF_MAX_INTEGRAL_DIGITS_FOR_DECIMAL`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@eyalroz eyalroz

Labels
resolved-on-develop A changeset fixing this issue has been commiutted to the development branch task testing Only relevant to the testing programs rather than the main code itself
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@eyalroz