Adopt a uniform, convenient, output gadget for the implementation functions #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eyalroz
force-pushed
the
fix-issue-32
branch
2 times, most recently
from
acf98a3 to
c519fd6
Compare
eyalroz
force-pushed
the
fix-issue-32
branch
2 times, most recently
from
d60e53b to
529476c
Compare
…entation for all library functions. Also, this merits a version bump. * Added: An `output_gadget_t` struct * Added: Named constructor idioms for `output_gadget_t`, instead of the function wrappers we have before: For `putchar_()` output, buffer output, discarding/no output, and arbitrary function output. * Implementation functions no longer need to maintain and pass around the parameters `buffer`, `maxlen`, `idx` - these are part of the uniform output gadget * Implementation functions no longer need to increase the position within the output (`idx)`, nor return the increased value to their caller. * No longer need a dummy buffer of size 1, anywhere.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #32.
Now using a convenient uniform gadget for the inner implementation functions.
output_gadget_tstructoutput_gadget_t, instead of the function wrappers we have before: Forputchar_()output, buffer output, discarding/no output, and arbitrary function output.buffer,maxlen,idx- these are part of the uniform output gadgetidx), nor return the increased value to their caller.