Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FoxyProxy Compatibility? #47

Closed
eyedeekay opened this issue Dec 25, 2019 · 4 comments · Fixed by #55
Closed

FoxyProxy Compatibility? #47

eyedeekay opened this issue Dec 25, 2019 · 4 comments · Fixed by #55
Labels
help very welcome If a concerned party wants to get to this before I can, it would be awesome. help wanted Extra attention is needed

Comments

@eyedeekay
Copy link
Owner

eyedeekay commented Dec 25, 2019

This extension currently Breaks the expected behavior of FoxyProxy by enforcing it's rules over those described by FoxyProxy. This one might be more trouble than it's worth, in fact I think it probably is, but if it isn't, this is a nice-to-have for some of the longtime Foxy users to ease their transition.

@eyedeekay eyedeekay added help wanted Extra attention is needed help very welcome If a concerned party wants to get to this before I can, it would be awesome. labels Dec 25, 2019
@eyedeekay
Copy link
Owner Author

What's the desirable behavior here and how do we get to it? I think what we might need to do is be able to ask FoxyProxy if the URL we're getting matches a pattern it recognizes and respond back with the proxy object we need to actually use. That might require reading FoxyProxy's storage, or maybe implementing an API in FoxyProxy that we can talk to? These are some things to think about, people have pretty elaborate FoxyProxy configurations that are working for them, it would be nice if we could work together.

@Thinkablemell0w
Copy link

Does it really make sense to add support for that?
I mean is there anyone who does have both installed and if so why would one do that ?

@eyedeekay
Copy link
Owner Author

eyedeekay commented Mar 2, 2020

Mostly I'm thinking legacy users? Like there are a lot of people using FoxyProxy for I2P right now, the configurations they use are inconsistent at best and sometimes highly customized. What's worse is that sometimes it might even be customized for a sane and valid reason. So if they want to keep using FoxyProxy, but also have a menu full of shortcuts and a proxy readiness indicator and protocol handlers for bittorrent and Snark-RPC integration, then they have to do that piecemeal with other extensions.

To be fair, it is pretty low-priority. But I'd accommodate it if I can.

@Thinkablemell0w
Copy link

I see, thanks for clarifying

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help very welcome If a concerned party wants to get to this before I can, it would be awesome. help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants