Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add container support #22

Closed
agyild opened this issue Jul 19, 2019 · 10 comments
Closed

Add container support #22

agyild opened this issue Jul 19, 2019 · 10 comments
Labels
feature request New feature or request

Comments

@agyild
Copy link

agyild commented Jul 19, 2019

Container support would allow using different proxy configurations depending on the container the domain has been visited in. (e.g. For domain example.com: use proxy A when visited in Work profile, use proxy B when visited in Personal, otherwise use proxy C).

@ericjung
Copy link
Collaborator

Hello agyild,

This will be added in a future release to FoxyProxy.

@foxyproxy foxyproxy deleted a comment from erosman Jul 20, 2019
@eyedeekay
Copy link

Interesting to me that this is coming up, I have been hanging proxy settings onto container tabs in my I2P in Private Browsing extension and would like to be able to retain compatibility with FoxyProxy, but I don't know how yet. I think we might run into similar issues with other extensions that container-ize tabs automatically based on URL's if FoxyProxy rules start to correspond to container tabs, the best solution might be to keep containers optional so that if a person has a conflicting extension they can turn it off?

@ericjung
Copy link
Collaborator

@eyedeekay proxy-through-containers will definitely be an option, not forced. Will that meet your needs?

@eyedeekay
Copy link

For other containerizers(Facebook/Google Container from Mozilla for instance) yes, and for all non-I2P proxies for me, yes, I think so. For I2P Proxies my extension will still probably be incompatible with FoxyProxy because, at least when I tested using them together, my extension settings seem to be used and not FoxyProxy's.

I could do what I do for Snowflake, that is, detect if FoxyProxy is installed and never mess with settings FoxyProxy needs, based on the assumption that the user is only using FoxyProxy to configure their proxy settings and only wants the container features of my plugin. However if I do that I would like to figure out some way to confirm that FoxyProxy has rules for I2P ready. I can't just make a request to proxy.i2p and see if it succeeds, because if no proxy is configured for .i2p domains(By FoxyProxy in this case) then it will leak, so I need a way to determine the presence of the settings without a request to preserve compatibility. If I can't figure out a good way to do that only in my extension, then I may need to request a way to "talk" to FoxyProxy to determine if rules are present to cover a particular pseudo-tld like *.i2p.

@bug-repport
Copy link

bug-repport commented Jan 28, 2020

Yes, very need this function! Relase please! (Add container support)

@ThiefMaster
Copy link

This would indeed be a great feature! Basically an option to use a proxy regardless of the URL as long as it's in a given container tab.

@bug-repport
Copy link

bug-repport commented May 15, 2020

This would indeed be a great feature! Basically an option to use a proxy regardless of the URL as long as it's in a given container tab.

Yes, it would be very cool if you could set up a proxy for a specific tab, and not a domain, this is a great idea!

although I already found the proxy container plugin ( https://addons.mozilla.org/ru/firefox/addon/container-proxy/ ) and it is excellent, but it would be great if it were implemented in foxy proxy

@vfsoraki
Copy link

This is a great feature to add. I switched to another addon just for this reason, though I will use FoxyProxy when it gets container support.

@cljoly
Copy link

cljoly commented Mar 15, 2021

I totally agree, I developed my own extension just for this reason.

@erosman erosman added the feature request New feature or request label Sep 9, 2022
@erosman
Copy link
Collaborator

erosman commented Sep 27, 2023

Follow on: Incognito & Container Support

@erosman erosman closed this as completed Sep 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request
Projects
None yet
Development

No branches or pull requests

8 participants