Cleanup internals #101
Merged
Cleanup internals #101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ten3roberts
commented
Aug 15, 2023
| @@ -22,7 +22,7 @@ thiserror = "1.0" | |||
| trybuild = { version = "1.0.19", features = ["diff"] } | |||
| backtrace = "0.3.46" | |||
| anyhow = "1.0.28" | |||
| syn = { version = "1.0", features = ["full"] } | |||
| syn = { version = "2.0", features = ["full"] } | |||
There was a problem hiding this comment.
This is what caused the failure of the src/macros.rs
The two versions of syn were conflicting with thiserror
|
Bringing this up to speed with recent changes in rustc using, such as renamed lints. Feel free to comment |
yaahc
approved these changes
Aug 15, 2023
src/macros.rs
Outdated
| @@ -40,7 +40,6 @@ | |||
| /// | |||
| /// # fn main() -> Result<()> { | |||
| /// # let depth = 0; | |||
| /// # let err: &'static dyn std::error::Error = &ScienceError::RecursionLimitExceeded; | |||
There was a problem hiding this comment.
I was looking at this for a minute trying to figure out why it was there... honestly still not really sure. I'm guessing it has something to do with asserting that ScienceError type implements error, but the bail! macro should do the same thing, sooooo.... Seems fine
edit: seeing you already restored, kinda curious if you figured out why it was necessary.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of getting to know the codebase I've started to do some spring cleaning