Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation on wrap_err vs wrap_err_with #93

Merged
merged 4 commits into from
Nov 24, 2023

Conversation

akshayknarayan
Copy link
Contributor

This PR adds documentation to address the issue described in eyre-rs/color-eyre#126.

src/lib.rs Outdated Show resolved Hide resolved
Copy link
Contributor

@thenorili thenorili left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, thanks so much for this contribution and for being so responsive to feedback :D

@thenorili thenorili enabled auto-merge (squash) November 22, 2023 08:03
@thenorili
Copy link
Contributor

This is ready to squash and merge when the merge conflicts are resolved : )

@thenorili thenorili merged commit 0979ad7 into eyre-rs:master Nov 24, 2023
29 checks passed
@thenorili
Copy link
Contributor

Thanks so much for your contribution again, the new docs look great! :D I'm still getting used to github PRs or I would've merged it myself, I've been using git+reviewboard for years ^^; I hope you have a great weekend.

@akshayknarayan
Copy link
Contributor Author

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants