Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clear func calls during flush #183

Merged
merged 1 commit into from
Mar 22, 2020
Merged

Conversation

Stanback
Copy link
Contributor

I ran into a bit of a memory "leak" when running, what do you recommend? It looks like the function call stack was getting filled up:

PHP Fatal error:  Allowed memory size of 4294967296 bytes exhausted (tried to allocate 536870920 bytes) in /htdocs/lib/vendor/ezsql/ezsql/lib/ezsqlModel.php on line 272

A solution is to clear it out during flush()..

@codecov-io
Copy link

codecov-io commented Mar 22, 2020

Codecov Report

Merging #183 into master will decrease coverage by 1.44%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #183      +/-   ##
============================================
- Coverage     86.36%   84.92%   -1.45%     
  Complexity      793      793              
============================================
  Files            14       14              
  Lines          1958     2003      +45     
============================================
+ Hits           1691     1701      +10     
- Misses          267      302      +35     
Impacted Files Coverage Δ Complexity Δ
lib/ezsqlModel.php 90.68% <100.00%> (+0.03%) 112.00 <0.00> (ø)
lib/Database/ez_sqlsrv.php 74.35% <0.00%> (-8.50%) 65.00% <0.00%> (ø%)
lib/ezQuery.php 75.15% <0.00%> (-2.25%) 204.00% <0.00%> (ø%)
lib/Database/ez_sqlite3.php 91.53% <0.00%> (+0.76%) 55.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update af0d882...a8ab3b4. Read the comment docs.

@TheTechsTech
Copy link
Contributor

TheTechsTech commented Mar 22, 2020

Seems reasonable, there needs to be a better way to keep track of all log calls.
It was added from a feature request some time ago, and memory will eventually get filled, the way it currently works, with no release.

@TheTechsTech TheTechsTech merged commit 2f87447 into ezSQL:master Mar 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants