-
-
Notifications
You must be signed in to change notification settings - Fork 254
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix(windows): rustc false dead code positives
Apparently, upstream rust decided to change the behavior of dead/unused code detection in a way that causes a lot of false positives. For some (yet known) reason, this only hit on the windows build, but I've confirmed that these are indeed false positives, and removing this "dead code" breaks the build. Frustratingly, we only hit this to fix *another issue*[1] with upstream rust... And this litters our code with directives where we "allow unused" that isn't unused. I coindicentally also saw this at dayjob today[2], and yes, this is real, so we'll just have to do it. Refs: [1] rust-lang/rust@e69f14b Refs: [2] DBCDK/faythe#101 Refs: rust-lang/rust#88900 Refs: #1342 Signed-off-by: Christina Sørensen <ces@fem.gg>
- Loading branch information
Showing
7 changed files
with
13 additions
and
1 deletion.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters