Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate from users lib to uzers #150

Merged
merged 3 commits into from
Aug 22, 2023
Merged

Conversation

gierens
Copy link
Member

@gierens gierens commented Aug 21, 2023

So, I ran cargo audit on eza and it warns that users (https://github.com/ogham/rust-users) is unmaintained, which makes sense since this is how eza came about :D ... So I thought since the uutils fellows are working on a term-grid fork, I would be good if all our other deps are also clean and maintained. So I forked rust-users to https://github.com/gierens/uzers-rs, reviewed and merged the existing pull requests, added CI workflows, cleaned up a bit, and published it to https://crates.io/crates/uzers .

This migrates the users dependency to said uzers.

Signed-off-by: Sandro-Alessio Gierens <sandro@gierens.de>
@gierens
Copy link
Member Author

gierens commented Aug 21, 2023

@cafkafk Since it's the same with ansi_term I'm going to look into this as well after lunch.

@gierens
Copy link
Member Author

gierens commented Aug 21, 2023

Also added uzers to the advisory database so cargo audit displays it as recommended alternative:
rustsec/advisory-db#1751

@cafkafk
Copy link
Member

cafkafk commented Aug 21, 2023

Maybe you'd want it in the eza-community org?

If you wanna maintain it from your account that's also fine imo, just thought I should mention the option in case.

Either way, a maintained version is definitely preferred.

@gierens
Copy link
Member Author

gierens commented Aug 21, 2023

I actually thought about that, but since I'm not in the maintainers list, I wasn't able to create a repo here. Since I already commented the new url in all the issues the advisory DB created in other repos, moving would mean changing all those again and that could create some confusion ... so I think it's easier to keep it how it is for now.

But for the ansi_term fork which I'm working on right now we could do it this way. I created a request to join maintainers so I can move it there.

@cafkafk
Copy link
Member

cafkafk commented Aug 21, 2023

On organization roles

I created a request to join maintainers so I can move it there.

I looked into permissions for doing this, and I can only give "repository roles" via teams on a repository level, not organizationally.

There are only two types of organizational roles:
2023-08-21_15-16

There is a feature to add more, but it's paid :(

The best I can do in the free tier seems to be enabling all organization members to create public repositories, which I have just done.

On team roles

I'm gonna think about the best way to structure repository permissions and then redo these very soon!

I think it makes sense to give out more permissions to you and @PThorpe92, so you can triage and do stuff like assign labels, or assigning yourself to issues etc, which I just realized today you couldn't!

Tell me if there is something you can't do that you should be able to do.

Signed-off-by: Sandro-Alessio Gierens <sandro@gierens.de>
@gierens
Copy link
Member Author

gierens commented Aug 22, 2023

I'm a little mystified as to why GitHub recognizes the intended change in Cargo.toml as merge conflict, but ok, weird! :D

Copy link
Member

@cafkafk cafkafk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Testing of code indicates it's working, moving from an unmaintained library to a maintained fork is a pretty easy conclusion. TY, merging! (after CI)

@cafkafk cafkafk merged commit a1ca9cd into eza-community:main Aug 22, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

2 participants