Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(exa PR) 1141: git: Use GIT_DIR env var to find the repo #30

Merged
merged 3 commits into from
Aug 4, 2023
Merged

Conversation

cafkafk
Copy link
Member

@cafkafk cafkafk commented Jul 29, 2023

@cafkafk cafkafk changed the title (exa PR) 1141 (exa PR) 1141: git: Use GIT_DIR env var to find the repo Jul 29, 2023
@cafkafk
Copy link
Member Author

cafkafk commented Jul 30, 2023

see: ogham/exa#722

@cafkafk cafkafk self-assigned this Jul 30, 2023
@sbatial sbatial mentioned this pull request Jul 30, 2023
63 tasks
@cafkafk cafkafk added this to the exa pulls done milestone Jul 31, 2023
@cafkafk cafkafk removed help wanted Extra attention is needed good first issue Good for newcomers looking for testers needs feedback labels Jul 31, 2023
Signed-off-by: Christina Sørensen <christina@cafkafk.com>
@cafkafk
Copy link
Member Author

cafkafk commented Jul 31, 2023

I'm probably testing this wrong, but I'm not able to get this to work, @iamkroot would you be willing to demonstrate how I would test this (and or check if it's working after the merge)?

@cafkafk cafkafk added needs feedback not ready for PRs that aren't finished labels Jul 31, 2023
@iamkroot
Copy link

iamkroot commented Aug 2, 2023

Even I'm not totally privy to all the git commands needed to replicate this. I have simply been using the git repo generated using yadm for backing up my dotfiles. So I'd suggest using that as a starting point. no need to track everything-

  1. you can just add a few files to stage
  2. export GIT_DIR=$HOME/.local/share/yadm/repo.git
  3. cd /path/to/dir/with/staged/files
  4. eza --git

@cafkafk
Copy link
Member Author

cafkafk commented Aug 2, 2023

I'm gonna try this out a bit later, have you tried if this branch works for you, I'm unsure if the merge broke your PR.

@iamkroot
Copy link

iamkroot commented Aug 2, 2023

Tried locally- the patch is good. No compile issues, and works as expected.

@cafkafk cafkafk added ready and removed not ready for PRs that aren't finished labels Aug 2, 2023
@cafkafk cafkafk merged commit fbd0fdc into main Aug 4, 2023
9 checks passed
@cafkafk cafkafk deleted the pr-1141 branch August 4, 2023 03:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants