-
-
Notifications
You must be signed in to change notification settings - Fork 211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(exa PR) 1204: Support time zone settings for Windows #5
Conversation
I don't have a windows box, and I'm not familiar with windows systems programming. Need testers/reviewers that can verify this is working.
|
I don't know rust and am unable to figure out how to resolve the compilation errors. Would be interested in testing it once those errors are resolved and also with resolving the errors. I have attached the output of Details❯ cargo build Compiling eza v0.10.9 (C:\Users\agrmo\projects\eza) error[E0432]: unresolved import `self::users` --> src\output\render\mod.rs:35:15 | 35 | pub use self::users::Render as UserRender; | ^^^^^ could not find `users` in `self` |
No worries, if @ariasuni doesn't get around to it first I'll make a branch for you tomorrow (life permitting). |
@agrmohit can you try this branch: https://github.com/daviessm/eza/tree/pr-867? It's the same as the pr-867 branch but fixes the build on Windows. |
Ok, I'll do some more fiddling. I don't use |
I can't reproduce this. My local time zone is GMT but we're in summer time so UTC+1. I created a file, checked its time, set my computer to be in Singapore (UTC+8), created a new file, ran the test again and finally set the clock back to UTC+1. All of them worked.: |
Awesome, thanks! Closing in favour of #58 |
ogham/exa#1204