Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(exa PR) 981: Don't show an error on stdout when there is no timezone info #50

Merged
merged 2 commits into from
Jul 29, 2023
Merged

(exa PR) 981: Don't show an error on stdout when there is no timezone info #50

merged 2 commits into from
Jul 29, 2023

Conversation

cafkafk
Copy link
Member

@cafkafk cafkafk commented Jul 29, 2023 •
edited
Loading

@cafkafk cafkafk changed the title (exa PR) 981 (exa PR) 981: Don't show an error on stdout when there is no timezone info Jul 29, 2023
@cafkafk
Copy link
Member Author

cafkafk commented Jul 29, 2023

@sbatial how do you feel about this, shouldn't this use eprintln!?

refs

https://doc.rust-lang.org/std/macro.eprintln.html

@sbatial
Copy link
Collaborator

sbatial commented Jul 29, 2023

depending on the original intentions, yes.

As far as I understand it debug! is for development purposes.
so eprintln! is probably better considering that is useful information for users

@cafkafk
fix: use eprintln instead
0f9b3bf 
Signed-off-by: Christina Sørensen <christina@cafkafk.com>
sbatial
sbatial approved these changes Jul 29, 2023
View reviewed changes
Copy link
Collaborator

@sbatial sbatial left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@cafkafk cafkafk merged commit f0a153f into main Jul 29, 2023
@sbatial sbatial deleted the pr-981 branch July 30, 2023 02:13
@sbatial sbatial mentioned this pull request Jul 30, 2023
Closed
63 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbatial sbatial sbatial approved these changes

Assignees
No one assigned
Labels
needs feedback
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cafkafk @sbatial @lefth