Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issue #87 #122

Merged
merged 4 commits into from
May 13, 2023
Merged

issue #87 #122

merged 4 commits into from
May 13, 2023

Conversation

alidevhere
Copy link
Contributor

Hii @ezeoleaf i would like to contribute to this issue.
Thanks for your good work

Copy link
Owner

@ezeoleaf ezeoleaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⭐ Looks good to me

@ezeoleaf
Copy link
Owner

ezeoleaf commented May 8, 2023

@alidevhere Thanks for your change and I think we can release it, but I would like to have a test for this new code :)

Can you add it?

@alidevhere
Copy link
Contributor Author

Yeah sure!

@alidevhere
Copy link
Contributor Author

@ezeoleaf
i have added test case for change.
Thanks.

@ezeoleaf ezeoleaf merged commit b0dda57 into ezeoleaf:main May 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants