Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: remove unneeded @types/colors package #319

Merged
merged 1 commit into from
May 4, 2022

Conversation

agilgur5
Copy link
Collaborator

@agilgur5 agilgur5 commented May 3, 2022

Summary

Remove @types/colors from devDeps as it's no longer necessary

Details

  • it had a deprecation warning on install stating that types were built-in now

    • confirmed that my editor picks up the types fine without and that builds still work
  • auto-alphabetize deps

  • update package-lock.json version to match package.json version

    • NPM did both of these automatically when I ran npm install

- it had a deprecation warning on install stating that types were
  built-in now
  - confirmed that my editor picks up the types fine without and that
    builds still work

- auto-alphabetize deps
- update package-lock.json version to match package.json version
  - NPM did both of these automatically when I ran `npm install`
@agilgur5 agilgur5 added the scope: dependencies Issues or PRs about updating a dependency label May 3, 2022
@ezolenko ezolenko merged commit e5b276b into ezolenko:master May 4, 2022
@agilgur5 agilgur5 added the kind: internal Changes only affect the internals, and _not_ the public API or external-facing docs label May 26, 2022
@agilgur5 agilgur5 deleted the deps-remove-types-colors branch July 2, 2023 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind: internal Changes only affect the internals, and _not_ the public API or external-facing docs scope: dependencies Issues or PRs about updating a dependency
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants