Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

optim: don't getScriptSnapshot when we already have the snapshot #341

Merged
merged 1 commit into from
Jun 7, 2022
Merged

optim: don't getScriptSnapshot when we already have the snapshot #341

merged 1 commit into from
Jun 7, 2022

Conversation

agilgur5
Copy link
Collaborator

@agilgur5 agilgur5 commented Jun 4, 2022

Summary

Tiny one-line optimization: getScriptSnapshot was called when we already have the snapshot

Details

@agilgur5
optim: don't getScriptSnapshot when we already have the snapshot
e947827 
- the snapshot is set above, so no need to get it
- also the snapshot from above is used below already, so this doesn't
  seem to be intentional
  - it originates from 2d33064 which
    similarly doesn't seem intentional
@agilgur5 agilgur5 added the kind: optimization Performance, space, size, etc improvement label Jun 4, 2022
@ezolenko ezolenko merged commit d8a8e42 into ezolenko:master Jun 7, 2022
@agilgur5 agilgur5 deleted the optim-snapshot branch July 2, 2023 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
kind: optimization Performance, space, size, etc improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@agilgur5 @ezolenko