refactor: split out a common typecheckFile
func
#344
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Split out a common
typecheckFile
function used in 3+ places to DRY up more codeDetails
this is used in 3 places and going to be more for the code I'm adding to fix type-only imports in fix: type-check
include
d files missed bytransform
(type-only files) #345 (and probably more type-only PRs in the future)noErrors = false
in one place while others had it in anotherprintDiagnostics
technically, now
getDiagnostics
(from refactor: prefer native methods to lodash where possible #328) is now only used intypecheckFile
, so I could combine the two together, but I'm refactoring that one up a little