Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clean: remove redundant allImportedFiles check in _onwrite #346

Conversation

agilgur5
Copy link
Collaborator

@agilgur5 agilgur5 commented Jun 5, 2022

Summary

Remove an old, redundant check against allImportedFiles that is actually dead code

Details

  • this checks if any of the files in parsedConfig.fileNames are not in allImportedFiles, but all the files in parsedConfig.fileNames are explicitly added in the options hook on line 98

    • so this is redundant / dead code; the check will never be true
  • this can be considered a remnant of an old bug as an old commit fixed a bug with allImportedFiles after it was released: fix: don't skip emitting type declarations for included files #176

- this checks if any of the files in `parsedConfig.fileNames` are _not_
  in `allImportedFiles`, but all the files in `parsedConfig.fileNames`
  are explicitly added in the `options` hook on line 98
  - so this is redundant / dead code; the check will never be true

- this can be considered a remnant of an old bug as an old commit fixed
  a bug with `allImportedFiles` after it was released:
  ezolenko@f24359e
@agilgur5 agilgur5 added the kind: internal Changes only affect the internals, and _not_ the public API or external-facing docs label Jun 5, 2022
@ezolenko ezolenko merged commit c0fb53d into ezolenko:master Jun 7, 2022
@agilgur5 agilgur5 deleted the clean-remove-redundant-allImportedFiles-check branch July 2, 2023 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind: internal Changes only affect the internals, and _not_ the public API or external-facing docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants