test: increase no-errors integration timeout to 20s
#425
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- this was still occassionally failing on CI at 15s, so bump up a bit - c.f. https://github.com/ezolenko/rollup-plugin-typescript2/actions/runs/3075482590/jobs/4968935300, https://github.com/ezolenko/rollup-plugin-typescript2/actions/runs/3038898669/jobs/4893183507, https://github.com/ezolenko/rollup-plugin-typescript2/actions/runs/3038898669/jobs/4893561438, and many more - only `no-errors` was timing out, which makes sense, since it does 3 builds for the first test to test against the cache - this potentially could be optimized, but it started getting complicated to do so (including some concurrency issues) - so punting on that for now and just increasing the timeout
agilgur5
added
kind: internal
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Increase the timeout on the
no-errorsintegration test suiteDetails
no-errorswas timing out, which makes sense, since it does 3 builds for the first test to test against the cacheNote that these have never timed out on me locally, only in CI 🤷