Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add links in documentation #1

Open
joshlf opened this issue Aug 8, 2017 · 16 comments
Open

Add links in documentation #1

joshlf opened this issue Aug 8, 2017 · 16 comments

Comments

@joshlf
Copy link
Collaborator

joshlf commented Aug 8, 2017

Currently, most documentation comments do not include hyperlinks to other documentation when referencing other Rust objects.

@lambdude
Copy link

I'm working on this.

@joshlf
Copy link
Collaborator Author

joshlf commented Sep 14, 2017

Awesome, thanks!

@joshlf
Copy link
Collaborator Author

joshlf commented Feb 24, 2018

Now that implied short links (rust-lang/rust#48335) have been merged, this should be easier.

@JaromirCharles
Copy link
Contributor

Is there still work to be done on this issue?

@joshlf
Copy link
Collaborator Author

joshlf commented Apr 10, 2018

@lambdude Have you continued working on this?

@lambdude
Copy link

Sorry, I have not been able to continue working on this.

@JaromirCharles
Copy link
Contributor

@joshlf I'd like to pick up this issue then.

@joshlf
Copy link
Collaborator Author

joshlf commented Apr 10, 2018

It's all yours then! I'll warn you that you might want to leave the elfmalloc crate to the end because we're in the middle of a large refactor now, so there's a decent chance those changes will land while you're working on this. Of course, if they haven't by the time you get there, then cool.

@JaromirCharles
Copy link
Contributor

@joshlf I've started to work on this issue and I have a question to ensure that i'm doing the right thing.
Here you can look into my branch on which the work is being done. Within the lines [8, 40] you can see that I've added links to the mentioned rust objects.
According to the new short links, i should be able to write [std::println] instead of [println] and then [println]: ../std/macro.println.html. Unfortunately it's not working.
If I'm doing it wrong, can you please leave an example of how it's done so that I can continue with that notation instead of the current one I'm doing. Thanks

@joshlf
Copy link
Collaborator Author

joshlf commented Apr 16, 2018

Hmm, unfortunately I'm not sure. I've never actually tried to do this myself (in this project or any other one), so I don't know any more about it than you do. I often find the rust-lang users' forum to be a good resource for this sort of stuff - if you post a simple example of what you expect to work that doesn't work, somebody will probably be able to tell you where you're going wrong.

@JaromirCharles
Copy link
Contributor

@joshlf
Unfortunately i did not have much time the past few days.
I just made a PR with the changes made to alloc-fmt. If you're satisfied with the way it is, i'll get the others done asap in the same manner.

@joshlf
Copy link
Collaborator Author

joshlf commented Apr 26, 2018

Awesome, thanks for that PR! My only comments were with the commit messages; the code itself seemed to work perfectly. And don't feel rushed in this 😀 Lord knows I've not had time for this over the past few weeks.

@JaromirCharles
Copy link
Contributor

@joshlf i think i messed up the merging of the commits.

@joshlf
Copy link
Collaborator Author

joshlf commented May 3, 2018

@JaromirCharles Sorry I went AWOL for a bit, but it looks like you figured it out, so I merged the PR 😃 . Thanks!

@JaromirCharles
Copy link
Contributor

@joshlf Whats the best way of moving forward?
My thought was to create a new branch for each crate and then merge them together as the PR goes through. The only problem would be that the merge commit would be the last commit message no?

@JaromirCharles
Copy link
Contributor

Below is the current log trace after the merge of alloc-fmt and alloc-tls:

JaromirCharles    alloc-fmt: Add links to documentation    a5d0114
JaromirCharles    alloc-tls: Add links to documentation    3d5ced2
JaromirCharles    Merge branch 'alloc_fmt_docu' into alloc_tls_docu    33b0b3c

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants