Skip to content

Implement implied shortcut links for intra-rustdoc-links #48335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Feb 22, 2018
Merged

Implement implied shortcut links for intra-rustdoc-links #48335

merged 5 commits into from
Feb 22, 2018

Conversation

Manishearth
Copy link
Member

@Manishearth Manishearth commented Feb 18, 2018 •
edited
Loading

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 18, 2018
This was referenced Feb 18, 2018
Closed
Closed
@QuietMisdreavus
Copy link
Contributor

Shouldn't this wait until the referenced PR is merged upstream and set into a release?

@Manishearth
Copy link
Member Author

Yes, that's why it says "needs X".

I'm putting this up for testing and review 😄

@QuietMisdreavus QuietMisdreavus added S-blocked Status: Blocked on something else such as an RFC or other implementation work. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 19, 2018
@Manishearth Manishearth removed the S-blocked Status: Blocked on something else such as an RFC or other implementation work. label Feb 19, 2018
@Manishearth
Copy link
Member Author

Raph did a release, ready to land.

r?

@QuietMisdreavus
Copy link
Contributor

Dang, that came together fast. r=me pending travis

@Manishearth
Copy link
Member Author

@bors r=QuietMisdreavus

@bors
Copy link
Collaborator

bors commented Feb 19, 2018

📌 Commit 5fdc10c has been approved by QuietMisdreavus

@bors bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Feb 19, 2018
Manishearth added a commit to Manishearth/rust that referenced this pull request Feb 19, 2018
@Manishearth
Rollup merge of rust-lang#48335 - Manishearth:shortcut-links, r=Quiet…
c787251 
…Misdreavus

Implement implied shortcut links for intra-rustdoc-links

cc rust-lang#43466

Needs pulldown-cmark/pulldown-cmark#126

r? @QuietMisdreavus
@Manishearth Manishearth mentioned this pull request Feb 19, 2018
Closed
@Manishearth Manishearth mentioned this pull request Feb 19, 2018
Closed
Manishearth added a commit to Manishearth/rust that referenced this pull request Feb 20, 2018
@Manishearth
Rollup merge of rust-lang#48335 - Manishearth:shortcut-links, r=Quiet…
f8b640c 
…Misdreavus

Fixes rust-lang#47311.
r? @nrc
bors added a commit that referenced this pull request Feb 20, 2018
@bors
Auto merge of #48350 - Manishearth:rollup, r=Manishearth
46c318b 
Rollup of 17 pull requests

- Successful merges: #48052, #48072, #48082, #48083, #48084, #48106, #48123, #48157, #48185, #48197, #48198, #48206, #48208, #48221, #48258, #48314, #48335
- Failed merges:
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Feb 21, 2018
@GuillaumeGomez
Rollup merge of rust-lang#48335 - Manishearth:shortcut-links, r=Quiet…
fe1293f 
…Misdreavus

Implement implied shortcut links for intra-rustdoc-links

cc rust-lang#43466

Needs pulldown-cmark/pulldown-cmark#126

r? @QuietMisdreavus
@GuillaumeGomez GuillaumeGomez mentioned this pull request Feb 21, 2018
Merged
bors added a commit that referenced this pull request Feb 22, 2018
@bors
Auto merge of #48399 - GuillaumeGomez:rollup, r=GuillaumeGomez
b1f8e6f 
Rollup of 12 pull requests

- Successful merges: #47379, #47833, #48106, #48198, #48314, #48325, #48335, #48352, #48354, #48360, #48382, #48397
- Failed merges:
@bors bors merged commit 5fdc10c into rust-lang:master Feb 22, 2018
@joshlf joshlf mentioned this pull request Feb 24, 2018
Open
@jonhoo
Copy link
Contributor

jonhoo commented Feb 24, 2018

I wonder if this should be tracked for relnotes. It's such a win for well-interlinked documentation that as many people as possible should be aware of it!

@Manishearth
Copy link
Member Author

Manishearth commented Feb 24, 2018 via email

@jonhoo
Copy link
Contributor

jonhoo commented Feb 24, 2018

Sorry, what I meant is that when this does stabilize, and #43466 is brought up, the feature landed in this PR specifically should be highlighted.

@Manishearth Manishearth deleted the shortcut-links branch February 27, 2018 03:27
@crumblingstatue
Copy link
Contributor

This is amazing, but is it known that this doesn't work for backticked paths?

Implements [Iterator]. Yeah, it implements [`Iterator`]. Yup, [Iterator]. renders as:

Backticks are allowed in implied reference links in the RFC.

@QuietMisdreavus
Copy link
Contributor

That's supposed to work with this PR, given that the intra-links test verifies that shortcut links with backticks properly resolve. >_>

@Manishearth
Copy link
Member Author

idk why the test passes, the current implementation doesn't seem to work here (I thought it would but on second thoughts it's missing some things); I need to fix that 😄

@crumblingstatue crumblingstatue mentioned this pull request Mar 19, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@QuietMisdreavus QuietMisdreavus

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Manishearth @QuietMisdreavus @bors @jonhoo @crumblingstatue @rust-highfive