EZEE-2950: Inject drag-mock using Webpack Encore #121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mnocon
changed the title
mnocon
requested review from
bogusez,
katarzynazawada,
micszo and
tomaszszopinski
mnocon
force-pushed
the
EZEE-2950-use-webpack
branch
from
e2a521d to
3fa21df
Compare
katarzynazawada
approved these changes
Jan 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA: https://jira.ez.no/browse/EZEE-2950
Doc this is based on: https://doc.ezplatform.com/en/latest/guide/bundles/#configuration-from-a-bundle
Green build with all tests passing: https://github.com/ezsystems/ezplatform-page-builder/pull/477
Companion PR, removing the code from AdminUI: ezsystems/ezplatform-admin-ui#1201
Changing how the dragMock library is loaded - now it's added to the Page automatically in the
behatSymfony env, which should make the tests a lot faster (there is no need to load the library for every drag and drop interaction separately).@dew326 If you could please have a look at the
ez.config.manager.jsfile, as I'm pretty sure it's not perfect 😄 I had to make sure page-builder and form-builder entries are present, otherwise this would fail on Open Source version.@DominikaK I wrote a tiny bit of doc, could you have a look?