EZP-31261: UDW tree is not loaded properly when switching from Bookma…

…rks tab
ezsystems · Jan 20, 2020 · 7ec5b9a · 7ec5b9a
1 parent 4fa32e5
commit 7ec5b9a
Show file tree

Hide file tree

Showing 5 changed files with 11 additions and 10 deletions.
diff --git a/src/modules/universal-discovery/components/finder/finder.branch.js b/src/modules/universal-discovery/components/finder/finder.branch.js
@@ -41,7 +41,7 @@ const FinderBranch = ({ locationData }) => {
     let resizeStartPositionX = 0;
     let branchCurrentWidth = 0;
     const loadMore = ({ target }) => {
-        const areAllItemsLoaded = loadedLocations.location && locationData.subitems.length >= loadedLocations.location.childCount;
+        const areAllItemsLoaded = locationData.subitems.length >= loadedLocations.totalCount;
         const isOffsetReached = target.scrollHeight - target.clientHeight - target.scrollTop < SCROLL_OFFSET;
 
         if (areAllItemsLoaded || !isOffsetReached || isLoading) {

diff --git a/src/modules/universal-discovery/components/grid-view/grid.view.js b/src/modules/universal-discovery/components/grid-view/grid.view.js
@@ -26,7 +26,7 @@ const GridView = () => {
         true
     );
     const loadMore = ({ target }) => {
-        const areAllItemsLoaded = loadedLocations.location && locationData.subitems.length >= loadedLocations.location.childCount;
+        const areAllItemsLoaded = locationData.subitems.length >= loadedLocations.totalCount;
         const isOffsetReached = target.scrollHeight - target.clientHeight - target.scrollTop < SCROLL_OFFSET;
 
         if (areAllItemsLoaded || !isOffsetReached || isLoading) {

diff --git a/src/modules/universal-discovery/content.create.tab.module.js b/src/modules/universal-discovery/content.create.tab.module.js
@@ -61,7 +61,7 @@ const ContentCreataTabModule = () => {
                 const parentLocationData = clonedLoadedLocations[clonedLoadedLocations.length - 1];
 
                 parentLocationData.subitems = [];
-                parentLocationData.location.childCount = parentLocationData.location.childCount + 1;
+                parentLocationData.totalCount = parentLocationData.totalCount + 1;
 
                 dispatchLoadedLocationsAction({ type: 'SET_LOCATIONS', data: clonedLoadedLocations });
                 dispatchSelectedLocationsAction({ type: 'ADD_SELECTED_LOCATION', location: items[0] });

diff --git a/src/modules/universal-discovery/hooks/useFindLocationsByParentLocationIdFetch.js b/src/modules/universal-discovery/hooks/useFindLocationsByParentLocationIdFetch.js
@@ -29,8 +29,7 @@ export const useFindLocationsByParentLocationIdFetch = (locationData, { sortClau
         if (
             !locationData.parentLocationId ||
             locationData.collapsed ||
-            ((locationData.location && locationData.subitems.length >= locationData.location.childCount) ||
-                locationData.subitems.length >= limit + offset)
+            (locationData.subitems.length >= locationData.totalCount || locationData.subitems.length >= limit + offset)
         ) {
             dispatch({ type: 'FETCH_END', data: {} });
 

diff --git a/src/modules/universal-discovery/services/universal.discovery.service.js b/src/modules/universal-discovery/services/universal.discovery.service.js
@@ -44,15 +44,17 @@ export const findLocationsByParentLocationId = (
 
                 return mappedSubitems;
             });
-
-            callback({
-                location: location.Location,
-                version: version.Version,
+            const locationData = {
+                location: location ? location.Location : null,
+                version: version ? version.Version : null,
+                totalCount: subitems.totalCount || 4,
                 subitems: subitemsData,
                 bookmarked: bookmark,
                 permissions,
                 parentLocationId,
-            });
+            };
+
+            callback(locationData);
         })
         .catch(showErrorNotification);
 };