EZP-31236: Added bootstrap tooltip for all nodes with attribute title #246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GrabowskiM
approved these changes
Jan 14, 2020
dew326
approved these changes
Jan 14, 2020
2 tasks
2 tasks
dew326
approved these changes
Jan 27, 2020
GrabowskiM
approved these changes
Jan 30, 2020
dew326
reviewed
Feb 3, 2020
| title: label, | ||
| tabIndex: '-1', | ||
| onClick: handleClick, | ||
| }; | ||
|
|
||
| attrs.className = disabled ? `${attrs.className} ${baseClassName}--disabled` : attrs.className; | ||
| attrs.className = type ? `${attrs.className} ${baseClassName}--${type}` : attrs.className; | ||
| attrs.disabled = disabled ? 'disabled' : false; |
There was a problem hiding this comment.
I think:
attrs.disabled = disabled should be okej
GrabowskiM
approved these changes
Feb 3, 2020
GrabowskiM
approved these changes
Feb 6, 2020
lucasOsti
force-pushed
the
EZP-31236-added-tooltips-as-new-ui-component
branch
from
fde4129 to
4db3dfb
Compare
GrabowskiM
approved these changes
Feb 11, 2020
dew326
approved these changes
Feb 11, 2020
dew326
requested changes
Feb 12, 2020
| @@ -244,6 +244,7 @@ export default class SubItemsModule extends Component { | |||
| */ | |||
| switchView(activeView) { | |||
| this.setState(() => ({ activeView })); | |||
| eZ.helpers.tooltips.hideAll(); | |||
There was a problem hiding this comment.
I would do it in the setState callback as change state can be postponed in react
dew326
requested changes
Feb 20, 2020
| @@ -247,7 +243,7 @@ export default class SubItemsModule extends Component { | |||
| * @memberof SubItemsModule | |||
| */ | |||
| switchView(activeView) { | |||
| this.setState(() => ({ activeView })); | |||
| this.setState(() => ({ activeView }), eZ.helpers.tooltips.hideAll()); | |||
There was a problem hiding this comment.
The second parameter in setState is a function. I don't know how this will work.
Suggested change
| this.setState(() => ({ activeView }), eZ.helpers.tooltips.hideAll()); | |
| this.setState(() => ({ activeView }), () => eZ.helpers.tooltips.hideAll()); |
dew326
approved these changes
Feb 20, 2020
GrabowskiM
approved these changes
Feb 21, 2020
katarzynazawada
approved these changes
Feb 24, 2020
…s to cretate class names for action buttons
lucasOsti
force-pushed
the
EZP-31236-added-tooltips-as-new-ui-component
branch
from
d35191c to
593dd39
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All PR’s to this ticket:
ezsystems/ezplatform-matrix-fieldtype#30
https://github.com/ezsystems/ezplatform-form-builder/pull/205
ezsystems/ezplatform-user#58
https://github.com/ezsystems/ezplatform-workflow/pull/106
https://github.com/ezsystems/date-based-publisher/pull/148
#246
ezsystems/ezplatform-admin-ui#1176
Checklist:
$ composer fix-cs)