IBX-154: Allowed to define if the alternative text for image field is required (2.5) #292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
adamwojs
commented
Jun 16, 2021
adamwojs
commented
dew326
requested changes
Jun 17, 2021
src/modules/multi-file-upload/services/multi.file.upload.service.js
Outdated
Show resolved
Hide resolved
| { fieldDefinitionIdentifier: mapping.nameFieldIdentifier, fieldValue: data.file.name }, | ||
| { | ||
| fieldDefinitionIdentifier: mapping.nameFieldIdentifier, | ||
| fieldValue: data.file.name |
There was a problem hiding this comment.
If multiline, the last item should have , at the end.
I think it was good with a single line, especially with that the second item also could be a single line now.
There was a problem hiding this comment.
Reverted to single line in a9149ae
| { | ||
| fieldDefinitionIdentifier: mapping.contentFieldIdentifier, | ||
| fieldValue: { fileName: data.file.name, data: data.fileReader.result.replace(/^.*;base64,/, '') }, | ||
| fieldValue: fileValue |
There was a problem hiding this comment.
Suggested change
| fieldValue: fileValue | |
| fieldValue: fileValue, |
|
PR updated according to code review suggestions. |
dew326
approved these changes
Jun 21, 2021
|
QA approved, checked on ez Platform Enterprise 2.5 with .diff |
piotrbisaga
approved these changes
Jun 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.