Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Behat] Moved AdminUI features #1094

Merged
merged 1 commit into from
Sep 26, 2019
Merged

[Behat] Moved AdminUI features #1094

merged 1 commit into from
Sep 26, 2019

Conversation

mnocon
Copy link
Member

@mnocon mnocon commented Sep 25, 2019

Question Answer
Tickets https://jira.ez.no/browse/EZP-30884
Bug fix? yes
New feature? no
BC breaks? no
Tests pass? yes
Doc needed? no
License GPL-2.0

The full regression builds are failing: https://travis-ci.com/ezsystems/ezplatform-page-builder/jobs/238853969

because it's not possible to separate from each other feature files from AdminUI: the "standard" ones and the new "personas"

Using definition like:

regression:
      suites:
          regression:
            paths:
              - '%paths.base%/vendor/ezsystems/ezplatform-admin-ui/features'

means that all feature files (both from "features" directory and "personas" subdirectory) will be taken into account, which causes the personas tests to be run as well.

I've decided to move the "standard" (running on admin) files to another directory, which allows us to separate them from others.

Companion PR:
https://github.com/ezsystems/ezplatform-page-builder/pull/395

Any names better than "standard" are more than welcome, coudn't find anything better 😉

Checklist:

  • Coding standards ($ composer fix-cs)
  • Ready for Code Review

@mnocon mnocon changed the title [WIP] [Behat] Moved AdminUI features [Behat] Moved AdminUI features Sep 25, 2019
@mnocon
Copy link
Member Author

mnocon commented Sep 26, 2019

@lserwatka this one can be merged, together with:
https://github.com/ezsystems/ezplatform-page-builder/pull/395

@lserwatka lserwatka merged commit fe5dd21 into ezsystems:1.5 Sep 26, 2019
mateuszdebinski pushed a commit that referenced this pull request Feb 13, 2024
…rm when translating content type (#1115)

IBX-6680: Disabled add field action in field definition form when translating content type (#1094)

Co-authored-by: Robert Swoboda <53216935+Gengar-i@users.noreply.github.com>
(cherry picked from commit 5421c82e82cea4dd286d1c037da7977214f3c329)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

4 participants