Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EZP-31086: Redirect based on router, not url alias #1122

Merged
merged 1 commit into from
Sep 14, 2020
Merged

EZP-31086: Redirect based on router, not url alias #1122

merged 1 commit into from
Sep 14, 2020

Conversation

damianz5
Copy link
Contributor

@damianz5 damianz5 commented Oct 29, 2019 •
edited
Loading

https://jira.ez.no/browse/EZP-31086

Question Answer
Tickets https://jira.ez.no/browse/EZP-31086
Bug fix? yes
New feature? no
BC breaks? no
Tests pass? should
Doc needed? no
License GPL-2.0

requires:
ezsystems/repository-forms#323

Checklist:

  • Coding standards ($ composer fix-cs)
  • Ready for Code Review

@damianz5 damianz5 force-pushed the redirect_fix branch 2 times, most recently from 6dbce36 to 7c0d7a6 Compare October 29, 2019 14:09
webhdx
webhdx approved these changes Oct 29, 2019
View reviewed changes
Copy link
Contributor

@webhdx webhdx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's okay now. One small thing I'd change is UrlRedirectProcessor name, SystemUrlRedirectProcessor is more descriptive.

@tomaszszopinski tomaszszopinski self-assigned this Sep 14, 2020
tomaszszopinski
tomaszszopinski approved these changes Sep 14, 2020
View reviewed changes
Copy link
Contributor

@tomaszszopinski tomaszszopinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA approved on eZPlatform-ee 2.5 with clone.

@lserwatka lserwatka merged commit 7518ff4 into ezsystems:1.5 Sep 14, 2020
@lserwatka
Copy link
Member

Could you merge it up?

lserwatka pushed a commit that referenced this pull request Sep 16, 2020
Revert "EZP-31086: Redirect based on router, not url alias (#1122)"
28cb3c1 
This reverts commit 7518ff4.
@lserwatka lserwatka mentioned this pull request Sep 16, 2020
Merged
lserwatka added a commit that referenced this pull request Sep 16, 2020
@lserwatka
Revert "EZP-31086: Redirect based on router, not url alias (#1122)" (#…
0292275 
…1487)

This reverts commit 7518ff4.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomaszszopinski tomaszszopinski tomaszszopinski approved these changes

@webhdx webhdx webhdx approved these changes

Assignees

@tomaszszopinski tomaszszopinski

Labels
QA approved
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@damianz5 @lserwatka @webhdx @tomaszszopinski