Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EZP-30918: Added RelationView to allow displaying restricted relation #1135

Merged
merged 8 commits into from
Nov 22, 2019

Conversation

mikadamczyk
Copy link
Contributor

@mikadamczyk mikadamczyk commented Nov 18, 2019

Question Answer
Tickets https://jira.ez.no/browse/EZP-30918
Bug fix? yes
New feature? no
BC breaks? no
Tests pass? yes
Doc needed? no
License GPL-2.0

This PR introduces new Relation View to display content's relations. When a user has no access to see restricted relation then proper information will be displayed.

Related PR: ezsystems/repository-forms#327

Location view:
Screen Shot 2019-11-18 at 11 23 13 AM

Edit view:
Screen Shot 2019-11-18 at 11 24 06 AM

Checklist:

  • Coding standards ($ composer fix-cs)
  • Ready for Code Review

src/lib/View/Provider/RelationView/Configured.php Outdated Show resolved Hide resolved
src/lib/View/RelationView.php Outdated Show resolved Hide resolved
src/bundle/Resources/config/routing.yml Outdated Show resolved Hide resolved
@webhdx
Copy link
Contributor

webhdx commented Nov 19, 2019

Didn't we intend to move from render(controller(...)) because it would be more efficient to render relation tables via simple for loop?

@mikadamczyk mikadamczyk requested a review from adamwojs November 19, 2019 10:52
@mikadamczyk mikadamczyk force-pushed the EZP-30918-restricted-relation branch 2 times, most recently from f4480ce to e16f4af Compare November 19, 2019 14:54
@mikadamczyk mikadamczyk force-pushed the EZP-30918-restricted-relation branch 2 times, most recently from de96f72 to ce6e1cb Compare November 20, 2019 12:41
@mikadamczyk mikadamczyk requested a review from ViniTou November 20, 2019 13:08
@mikadamczyk mikadamczyk force-pushed the EZP-30918-restricted-relation branch from 25d34c0 to 89b6fae Compare November 20, 2019 14:28
@micszo micszo self-assigned this Nov 21, 2019
@mikadamczyk mikadamczyk force-pushed the EZP-30918-restricted-relation branch from 160a922 to 19a2574 Compare November 21, 2019 13:39
@mikadamczyk mikadamczyk force-pushed the EZP-30918-restricted-relation branch from 19a2574 to 6bf9da5 Compare November 22, 2019 08:52
Copy link
Member

@micszo micszo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA Approved on eZ Platform EE v2.5.6 with diffs.
(Travis status: single TC NOK - known nondeterministic issue with tests known issue https://jira.ez.no/browse/EZP-30868)

@micszo micszo removed their assignment Nov 22, 2019
@lserwatka lserwatka merged commit a63899d into 1.5 Nov 22, 2019
@lserwatka lserwatka deleted the EZP-30918-restricted-relation branch November 22, 2019 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

7 participants