EZP-31266: Changing items order in Relation List doesn't work on Firefox #1180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mateuszdebinski
requested review from
GrabowskiM,
dew326,
konradoboza and
mateuszbieniek
dew326
reviewed
Jan 7, 2020
src/bundle/Resources/public/js/scripts/fieldType/ezobjectrelationlist.js
Outdated
Show resolved
Hide resolved
dew326
reviewed
Jan 7, 2020
| findOrderInputs().forEach((item) => item.addEventListener('blur', updateSelectedItemsOrder, false)); | ||
| findOrderInputs().forEach((item) => { | ||
| item.addEventListener('blur', updateSelectedItemsOrder, false); | ||
| item.addEventListener('change', focusOnElement, false); |
There was a problem hiding this comment.
If this is only on FF I don't see a point to attach this event in all browsers. Please add a check if it is FF and attach it only in this case.
There was a problem hiding this comment.
the added condition only for FF attach
dew326
reviewed
Jan 7, 2020
src/bundle/Resources/public/js/scripts/fieldType/ezobjectrelationlist.js
Show resolved
Hide resolved
src/bundle/Resources/public/js/scripts/fieldType/ezobjectrelationlist.js
Show resolved
Hide resolved
…ionlist.js Co-Authored-By: Dariusz Szut <dew326@gmail.com>
…ionlist.js Co-Authored-By: Dariusz Szut <dew326@gmail.com>
dew326
approved these changes
Jan 7, 2020
|
Why add prettier to packages.json? |
…n-Relation-List-doesnt-work-on-Firefox' into EZP-31266-Changing-items-order-in-Relation-List-doesnt-work-on-Firefox
mateuszbieniek
approved these changes
Jan 7, 2020
Mistake, when I install prettier and I didn't notice that package.json was added as well |
konradoboza
approved these changes
Jan 7, 2020
There was a problem hiding this comment.
@mateuszdebinski note for the future: make branch names a bit shorter - in this case, it could have been just: EZP-31266-relationlist_ordering_ff.
katarzynazawada
approved these changes
Jan 9, 2020
|
@adamwojs please merge. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Firefox for a long time has this error. The arrows aren't elements in their own right, so they can't be focused, therefore need to force focus on input when value changes
Checklist:
$ composer fix-cs)