EZP-29249: Changed texts in relation fields #1183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dew326
requested changes
Jan 8, 2020
| @@ -50,6 +50,11 @@ | |||
| &__hidden-column { | |||
| display: none; | |||
| } | |||
|
|
|||
| &__helper { | |||
| @@ -6,5 +6,6 @@ | |||
| {% set limit = 1 %} | |||
| {% set default_location = form.vars.default_location ? form.vars.default_location.id : null %} | |||
| {% set allowed_content_type_identifiers = form.parent.vars.value.fieldDefinition.fieldSettings.selectionContentTypes %} | |||
| {% set helper = 'ezobjectrelation.helper'|trans|desc('Stores a relation to a content object.') %} | |||
DominikaK
suggested changes
Jan 9, 2020
| @@ -6,5 +6,6 @@ | |||
| {% set limit = 1 %} | |||
| {% set default_location = form.vars.default_location ? form.vars.default_location.id : null %} | |||
| {% set allowed_content_type_identifiers = form.parent.vars.value.fieldDefinition.fieldSettings.selectionContentTypes %} | |||
| {% set helper = 'ezobjectrelation.helper'|trans|desc('Stores a relation to a content object.') %} | |||
There was a problem hiding this comment.
Suggested change
| {% set helper = 'ezobjectrelation.helper'|trans|desc('Stores a relation to a content object.') %} | |
| {% set helper = 'ezobjectrelation.helper'|trans|desc('Stores a Relation to a Content item.') %} |
| @@ -6,5 +6,6 @@ | |||
| {% set limit = form.parent.vars.value.fieldDefinition.validatorConfiguration.RelationListValueValidator.selectionLimit %} | |||
| {% set default_location = form.vars.default_location ? form.vars.default_location.id : null %} | |||
| {% set allowed_content_type_identifiers = form.parent.vars.value.fieldDefinition.fieldSettings.selectionContentTypes %} | |||
| {% set helper = 'ezobjectrelationlist.helper'|trans|desc('Stores relations to other content objects.') %} | |||
There was a problem hiding this comment.
Suggested change
| {% set helper = 'ezobjectrelationlist.helper'|trans|desc('Stores relations to other content objects.') %} | |
| {% set helper = 'ezobjectrelationlist.helper'|trans|desc('Stores Relations to other Content items.') %} |
| {% if limit != 0 %} | ||
| {{ 'ezobjectrelationlist.cta.limit'|trans({'%limit%': limit})|desc('Set up multiple relations with up to %limit% content items') }} | ||
| {% if limit != 1 %} | ||
| {{ 'ezobjectrelationlist.cta.limit.multi'|trans|desc('Set up multiple relations with one or several content items') }} |
There was a problem hiding this comment.
Suggested change
| {{ 'ezobjectrelationlist.cta.limit.multi'|trans|desc('Set up multiple relations with one or several content items') }} | |
| {{ 'ezobjectrelationlist.cta.limit.multi'|trans|desc('Set up multiple Relations with one or several Content items') }} |
| {% if limit != 1 %} | ||
| {{ 'ezobjectrelationlist.cta.limit.multi'|trans|desc('Set up multiple relations with one or several content items') }} | ||
| {% else %} | ||
| {{ 'ezobjectrelationlist.cta.limit.single'|trans|desc('Set up a relation with one content item') }} |
There was a problem hiding this comment.
Suggested change
| {{ 'ezobjectrelationlist.cta.limit.single'|trans|desc('Set up a relation with one content item') }} | |
| {{ 'ezobjectrelationlist.cta.limit.single'|trans|desc('Set up a Relation with one Content item') }} |
dew326
approved these changes
Jan 9, 2020
DominikaK
approved these changes
Jan 9, 2020
lucasOsti
approved these changes
Jan 9, 2020
katarzynazawada
approved these changes
Jan 14, 2020
|
@GrabowskiM could you merge it up? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added and changed texts in relations fields.
Checklist:
$ composer fix-cs)