Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EZP-31277: added server timezone offset support for ezdate widget #1185

Merged
merged 5 commits into from
Jan 21, 2020
Merged

EZP-31277: added server timezone offset support for ezdate widget #1185

merged 5 commits into from
Jan 21, 2020

Conversation

barw4
Copy link
Member

@barw4 barw4 commented Jan 9, 2020 •
edited
Loading

Question Answer
Tickets https://jira.ez.no/browse/EZP-31277
Bug fix? yes
New feature? no
BC breaks? no
Tests pass? yes
Doc needed? no
License GPL-2.0

flatpickr widget will now instantiate with server's timezone offset if provided, not just be the browser's one in order to handle different timezones.

Checklist:

  • Coding standards ($ composer fix-cs)
  • Ready for Code Review

@barw4 barw4 requested review from adamwojs, webhdx and ViniTou January 9, 2020 14:59
@barw4 barw4 self-assigned this Jan 9, 2020
@barw4 barw4 mentioned this pull request Jan 9, 2020
Closed
@ViniTou ViniTou requested a review from dew326 January 9, 2020 15:34
@ViniTou
Copy link
Contributor

ViniTou commented Jan 13, 2020

@barw4
Failure seems related
https://res.cloudinary.com/ezplatformtravis/image/upload/v1578669095/screenshots/5e1894278eaa8866166318-vendor_ezsystems_ezplatform-admin-ui_features_standard_contenttypefields_feature_31_xeu5od.png

@barw4
Copy link
Member Author

barw4 commented Jan 15, 2020

Ping @ViniTou @adamwojs @webhdx

@micszo micszo self-assigned this Jan 21, 2020
micszo
micszo requested changes Jan 21, 2020
View reviewed changes
Copy link
Member

@micszo micszo left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Steps:

  1. Create new CT with ezdate field. [OK, date is January 21, 2020]
  2. Save or Publish. [NOK, date is January 20, 2020]

(timezone set to Warsaw)

@barw4
Copy link
Member Author

barw4 commented Jan 21, 2020

Steps:

  1. Create new CT with ezdate field. [OK, date is January 21, 2020]
  2. Save or Publish. [NOK, date is January 20, 2020]

(timezone set to Warsaw)

Resolved in 45fa9fc

@barw4 barw4 requested review from micszo and dew326 January 21, 2020 14:02
micszo
micszo approved these changes Jan 21, 2020
View reviewed changes
Copy link
Member

@micszo micszo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA Approved on eZ Platform EE v2.5.8 with diff.

@micszo micszo removed their assignment Jan 21, 2020
@adamwojs adamwojs merged commit 07ab0c4 into 1.5 Jan 21, 2020
@adamwojs adamwojs deleted the EZP-31277 branch January 21, 2020 14:28
@adamwojs
Copy link
Member

Could you merge it up @barw4?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ViniTou ViniTou ViniTou approved these changes

@micszo micszo micszo approved these changes

@dew326 dew326 dew326 approved these changes

@mikadamczyk mikadamczyk mikadamczyk approved these changes

@adamwojs adamwojs adamwojs approved these changes

@webhdx webhdx Awaiting requested review from webhdx

Assignees

@barw4 barw4

Labels
Bug QA approved
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@barw4 @ViniTou @adamwojs @mikadamczyk @dew326 @micszo