EZP-31241: Changed behaviour for showing not checked value in checkbox #1187
Conversation
| @@ -19,7 +19,9 @@ | |||
| <div class="ez-content-field"> | |||
| <p class="ez-content-field-name">{{ fieldDefinition.name }}:</p> | |||
| <div class="ez-content-field-value"> | |||
| {% if ez_is_field_empty(content, fieldDefinition.identifier) %} | |||
| {% if ez_is_field_empty(content, fieldDefinition.identifier) and fieldDefinition.fieldTypeIdentifier is same as('ezboolean') %} | |||
| <em>{{ 'ezboolean.no'|trans|desc('No') }}</em> | |||
There was a problem hiding this comment.
I'm not sure if this is the way. I think in the case of ezboolean the field should be rendered even if it's empty.
|
Now there's small inconsistency - No (with capital letter) and yes (with lowercase letter) |
That's inconsistency that we have in whole system, as these are translation from xliff file: https://github.com/ezsystems/ezplatform-admin-ui/blob/1.5/src/bundle/Resources/translations/fieldtypes_preview.en.xliff#L10 |
|
True, the recent changes in labels were introduced in 3.0 only, so I don't think the change is necessary |
|
@GrabowskiM could you merge it up? |
Show 'No' in content view when checkbox is empty.
Checklist:
$ composer fix-cs)