EZP-31291: Fix Content Type creation filter on certain words such as "File" #1190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think this will be also in 2.5. Could you change the base branch to 1.5. |
peterkeung
force-pushed
the
instant-filter-file
branch
from
fab5017 to
092ae96
Compare
peterkeung
force-pushed
the
instant-filter-file
branch
from
092ae96 to
5da7c1f
Compare
|
Rebased against 1.5 now |
dew326
approved these changes
Jan 16, 2020
lucasOsti
approved these changes
Jan 16, 2020
GrabowskiM
approved these changes
Jan 16, 2020
micszo
approved these changes
Jan 16, 2020
|
Thank you @peterkeung ! |
|
@dew326 could you merge it up? |
|
@lserwatka @GrabowskiM took care of it together with his PR. |
|
Great! Thank you 🥇 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you try to filter the Content Type creation list, "File" does not work, nor does a bunch of words that are found in the HTML of the quick filter list (form, check, type, content, and more). This is because the filter is applied against the entire HTML of each item.