EZP-31347: Added functionality to show dropdown above select field #1218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dew326
requested changes
Jan 31, 2020
| if (isListHidden) { | ||
| const viewportHeight = window.innerHeight || document.documentElement.clientHeight; | ||
| const { top } = this.itemsContainer.getBoundingClientRect(); | ||
|
|
|
|
||
| this.itemsContainer.classList.toggle(CLASS_ITEMS_HIDDEN); | ||
| doc.body[methodName]('click', this.onClickOutside, false); | ||
|
|
||
| const bodyMethodName = isListHidden ? 'addEventListener' : 'removeEventListener'; |
There was a problem hiding this comment.
can be moved before the iff to the other const
dew326
reviewed
Feb 3, 2020
| @@ -8,6 +8,8 @@ | |||
| &__items { | |||
| border: none; | |||
| box-shadow: 0 calculateRem(2px) calculateRem(4px) 0 rgba(0, 0, 0, 0.45); | |||
| max-height: calculateRem(300px); | |||
| overflow-y: scroll; | |||
There was a problem hiding this comment.
always scroll? I think better will be auto
dew326
approved these changes
Feb 3, 2020
lucasOsti
approved these changes
Feb 3, 2020
bogusez
approved these changes
Feb 3, 2020
|
Could you merge it up? |
|
Merge up done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Select list now will be positioned above select field if there is less than 300px to the bottom of screen.
Checklist:
$ composer fix-cs)