EZP-30639: Used Content view instead of deprecated Location view #1225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
dew326
requested changes
Feb 5, 2020
| @@ -78,7 +78,7 @@ | |||
| }) | |||
| .catch(eZ.helpers.notification.showErrorNotification); | |||
| }; | |||
| const generateLink = (locationId) => Routing.generate('_ezpublishLocation', { locationId }); | |||
| const generateLink = (contentId, locationId) => Routing.generate('_ez_content_view', { contentId, locationId }); | |||
There was a problem hiding this comment.
This is kind of BC break, the contentId should be added as a second parameter not first.
Nattfarinn
force-pushed
the
ezp-30639-deprecate-view-location
branch
from
2d12fdb to
ca90f01
Compare
GrabowskiM
approved these changes
Feb 6, 2020
dew326
approved these changes
Feb 6, 2020
adamwojs
approved these changes
Feb 7, 2020
lucasOsti
approved these changes
Feb 11, 2020
Nattfarinn
force-pushed
the
ezp-30639-deprecate-view-location
branch
from
3120d2b to
b80502f
Compare
Nattfarinn
force-pushed
the
ezp-30639-deprecate-view-location
branch
from
467545b to
4ac2540
Compare
Nattfarinn
force-pushed
the
ezp-30639-deprecate-view-location
branch
from
4ac2540 to
20a7a73
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist:
$ composer fix-cs)