EZP-31367: Do not use translated node name for Location ID 1 in Content Tree #1230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
webhdx
force-pushed
the
location-1-ct-node-name
branch
from
7d64e0b to
15e03f0
Compare
webhdx
requested review from
adamwojs,
michal-myszka,
micszo,
mikadamczyk,
Nattfarinn and
ViniTou
adamwojs
approved these changes
Feb 11, 2020
mikadamczyk
approved these changes
Feb 11, 2020
michal-myszka
approved these changes
Feb 11, 2020
ViniTou
approved these changes
Feb 11, 2020
tomaszszopinski
approved these changes
Feb 11, 2020
|
Could you merge it up? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was discovered during testing of ezsystems/ezplatform-admin-ui-modules#264. For Location ID 1 there is no
VersionInfothus it is impossible to get translated name. As a fallback it uses$contentInfo->nameproperty.Checklist:
$ composer fix-cs)