EZP-31066: Error when clicking the link in RTE #1267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GrabowskiM
approved these changes
Mar 4, 2020
|
After internal sync with @dew326 I reverted typo fix as it causes BC breaks. However, it will be taken into account for 3.0. |
dew326
approved these changes
Mar 5, 2020
4 tasks
lucasOsti
approved these changes
Mar 5, 2020
tomaszszopinski
approved these changes
Mar 6, 2020
|
Could you merge it up? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When no toolbar is launched, there is JS error that freezes RTE. This PR just adds proper check for the toolbar existence and takes it into account when calculating the
topposition. Also, changed typo in the class name and all its references. PR for version 3.0 will be created once this one is approved.Checklist:
$ composer fix-cs)