Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EZP-31120: Image is not replaced in RTE/OE when publishing directly #1327

Merged
merged 1 commit into from
Apr 1, 2020
Merged

EZP-31120: Image is not replaced in RTE/OE when publishing directly #1327

merged 1 commit into from
Apr 1, 2020

Conversation

konradoboza
Copy link
Member

Question Answer
Tickets EZP-31120
Bug fix? yes
New feature? no
BC breaks? no
Tests pass? yes
Doc needed? no
License GPL-2.0

Updating an image doesn't invoke customUpdate event that results in changes being not reflected in the edition form.

Checklist:

  • Coding standards ($ composer fix-cs)
  • Ready for Code Review

@konradoboza konradoboza requested review from GrabowskiM and dew326 April 1, 2020 09:57
@konradoboza konradoboza self-assigned this Apr 1, 2020
@konradoboza konradoboza mentioned this pull request Apr 1, 2020
Merged
3 tasks
@dew326 dew326 requested a review from lucasOsti April 1, 2020 09:59
@konradoboza konradoboza removed their assignment Apr 1, 2020
@tomaszszopinski tomaszszopinski self-assigned this Apr 1, 2020
tomaszszopinski
tomaszszopinski approved these changes Apr 1, 2020
View reviewed changes
Copy link
Contributor

@tomaszszopinski tomaszszopinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA approved on eZPlatform EE 2.5 with diff.

@lserwatka lserwatka merged commit a3e88a5 into 1.5 Apr 1, 2020
@lserwatka lserwatka deleted the EZP-31120-images_not_replaced branch April 1, 2020 12:34
@lserwatka
Copy link
Member

Could you merge it up?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomaszszopinski tomaszszopinski tomaszszopinski approved these changes

@dew326 dew326 dew326 approved these changes

@GrabowskiM GrabowskiM GrabowskiM approved these changes

@lucasOsti lucasOsti Awaiting requested review from lucasOsti

Assignees

@tomaszszopinski tomaszszopinski

Labels
Bug QA approved
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@konradoboza @lserwatka @GrabowskiM @dew326 @tomaszszopinski