EZP-31547: Autowiring fails for CustomTag service when using 3rd party translator bundle

[mateuszbieniek]

Question	Answer
Tickets	https://jira.ez.no/browse/EZP-31547
Bug fix?	yes

This is continuation for #1058

This PR adds $translator argument to EzSystems\EzPlatformAdminUi\UI\Config\Mapper\FieldType\RichText\CustomTag to prevent autowiring issues.

[mateuszbieniek]

As mentioned by @webhdx #1007 (comment) here, the provided solution seems like overkill, but without we will encounter issues like EZP-31547.

Another alternative would be solution used by Symfony, but I'm not sold.

    /**
     * @var TranslatorInterface|TranslatorBagInterface
     */
    private $translator;
    /**
     * @param TranslatorInterface $translator The translator must implement TranslatorBagInterface
     */
    public function __construct(TranslatorInterface $translator)
    {
        if (!$translator instanceof TranslatorBagInterface) {
            throw new InvalidArgumentException(sprintf('The Translator "%s" must implement TranslatorInterface and TranslatorBagInterface.', \get_class($translator)));
        }

        $this->translator = $translator;
    }

WDYT?

[alongosz]

I prefer approach with two separate interfaces, as-is ATM, even though ATM it's the same Service. It's more SOLID.
Keep in mind that merge up might require extra effort due to switch to \Symfony\Contracts.

[tomaszszopinski]

QA approved on eZPlatform 2.5 EE with patch & diff.

[mateuszbieniek]

Merge up for ezplatform-richtext:
ezsystems/ezplatform-richtext#142