Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EZEE-3071: Moved generate key for SiteAccess to new Class #1369

Merged
merged 10 commits into from
May 20, 2020
Merged

EZEE-3071: Moved generate key for SiteAccess to new Class #1369

merged 10 commits into from
May 20, 2020

Conversation

mateuszdebinski
Copy link
Contributor

@mateuszdebinski mateuszdebinski commented May 6, 2020 •
edited
Loading

Question Answer
JIRA issue EZEE-3071
Type bug/improvement
BC breaks no
Tests pass yes
Doc needed no
License GPL-2.0

Another PR for this ticket: https://github.com/ezsystems/ezplatform-site-factory/pull/58

Checklist:

  • Coding standards ($ composer fix-cs)
  • Ready for Code Review

@mateuszdebinski mateuszdebinski changed the title EZEE-3071: Moced generate key for SiteAccess to new Class EZEE-3071: Moved generate key for SiteAccess to new Class May 7, 2020
@mateuszdebinski
Copy link
Contributor Author

Tests passed: https://travis-ci.com/github/ezsystems/ezplatform-page-builder/builds/166246555

webhdx
webhdx approved these changes May 15, 2020
View reviewed changes
src/lib/Siteaccess/SiteAccessKeyGenerator.php Outdated Show resolved Hide resolved
@micszo micszo self-assigned this May 20, 2020
micszo
micszo approved these changes May 20, 2020
View reviewed changes
Copy link
Member

@micszo micszo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with https://github.com/ezsystems/ezplatform-site-factory/pull/58.

@micszo micszo removed their assignment May 20, 2020
@lserwatka lserwatka merged commit d79a488 into 2.0 May 20, 2020
@lserwatka lserwatka deleted the EZEE-3071 branch May 20, 2020 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mateuszbieniek mateuszbieniek mateuszbieniek approved these changes

@konradoboza konradoboza konradoboza approved these changes

@micszo micszo micszo approved these changes

@webhdx webhdx webhdx approved these changes

@mikadamczyk mikadamczyk Awaiting requested review from mikadamczyk

Assignees
No one assigned
Labels
Bug QA approved
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@mateuszdebinski @webhdx @micszo @konradoboza @mateuszbieniek @lserwatka