Fixed EZP-31639: media and file fields not loaded correctly in edit mode #1391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamwojs
changed the title
adamwojs
requested review from
mikadamczyk,
alongosz,
michal-myszka,
Nattfarinn,
ViniTou and
webhdx
Nattfarinn
approved these changes
May 27, 2020
alongosz
approved these changes
May 27, 2020
Co-authored-by: Andrew Longosz <alongosz@users.noreply.github.com>
ViniTou
approved these changes
May 27, 2020
mnocon
approved these changes
May 28, 2020
There was a problem hiding this comment.
The issue is gone, so +1
But except for:
Issue discovered while testing: the content preview / edit view doesn't take current translation language into account when displaying field value. We need follow up story here.
it looks like there is another issue, is something wrong related to drafts - when while editing Content a new video is added and Content is saved as a draft the previous video is still displayed.
I will create the follow ups so we can investigate it.
|
@mnocon could you add ticket for this follow up here? |
|
@lserwatka The ticket is here: https://jira.ez.no/browse/EZP-31660 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR: URLs to binary content of ezmedia/ezfile fields used in ezplatform-admin-ui should generated in scope of the current siteaccess, otherwise additional auth. might be required if resource is not public available e.g. specific versions (sessions are not shared between siteaccesses by default).
Alternative solution
Pass
siteaccessparameter explicitly toez_content_downloadroute to force url generation in specific siteaccess. it's not as easy as it sounds seeez_content_download_field_idrouteCreate dedicated download controller for ezplatform-admin-ui (
ez_content_downloadis designed to be used in frontend)Known issues
Issue discovered while testing: the content preview / edit view doesn't take current translation language into account when displaying field value. We need follow up story here.
Checklist:
$ composer fix-cs)