EZP-31651: Decoupled Search Bundle from AdminUI #1404
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
ViniTou
requested review from
michal-myszka,
adamwojs,
alongosz,
mikadamczyk,
Nattfarinn and
webhdx
adamwojs
approved these changes
Jun 22, 2020
ViniTou
force-pushed
the
ezp-31651-cutomizable-search
branch
2 times, most recently
from
730459c to
f8d67b1
Compare
ViniTou
force-pushed
the
ezp-31651-cutomizable-search
branch
from
f8d67b1 to
2cb46e9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Desc:
adding
user_content_type_identifierparameter to view was moved to adminUI, as this is where this param is declared.SearchForm and Data was moved to new bundle, with BC layer of
class_aliasAll form types/data mappers and co. that was needed for search type to run was copied 1:1 to new bundle, as they are to generic to moved them.
EzSystems\EzPlatformAdminUi\Search\AbstractPagerContentToDataMapperwas moved toEzSystems\EzPlatformAdminUi\Pagination\Mapper\AbstractPagerContentToDataMapper; As it also handles Dashboard I would say it should not be inSearchnamespace from beginning.Search Bundle PR
ezsystems/ezplatform-search#3
Green regression build
https://travis-ci.com/github/ezsystems/ezplatform-page-builder/builds/172636991
Checklist:
$ composer fix-cs)