Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EZP-31692: Hide tooltip after show/hide details of content #1415

Merged
merged 1 commit into from
Jul 3, 2020
Merged

EZP-31692: Hide tooltip after show/hide details of content #1415

merged 1 commit into from
Jul 3, 2020

Conversation

lucasOsti
Copy link
Contributor

@lucasOsti lucasOsti requested review from GrabowskiM and dew326 June 30, 2020 14:43
@dew326
Copy link
Member

dew326 commented Jul 1, 2020

Is this valid for 3.0?

@lucasOsti
Copy link
Contributor Author

Is this valid for 3.0?

in 3.0 we don't have a title for button "question mark"

@dew326
Copy link
Member

dew326 commented Jul 1, 2020

So the question is should we have a tooltip there?

@lucasOsti lucasOsti force-pushed the EZP-31692-question-mark branch from 1472a74 to 8fccea0 Compare July 1, 2020 10:01
@lucasOsti lucasOsti changed the base branch from master to 2.0 July 1, 2020 10:02
tomaszszopinski
tomaszszopinski approved these changes Jul 3, 2020
View reviewed changes
Copy link
Contributor

@tomaszszopinski tomaszszopinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA approved on eZ Platform ee 3.0.5 with diff.

@lserwatka lserwatka merged commit 560080c into ezsystems:2.0 Jul 3, 2020
@lserwatka
Copy link
Member

You can merge it up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomaszszopinski tomaszszopinski tomaszszopinski approved these changes

@dew326 dew326 dew326 approved these changes

@GrabowskiM GrabowskiM GrabowskiM approved these changes

Assignees
No one assigned
Labels
QA approved
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@lucasOsti @dew326 @lserwatka @GrabowskiM @tomaszszopinski