Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EZP-31743: Multi-input single field validation doesn't show proper error #1435

Merged
merged 1 commit into from
Jul 20, 2020
Merged

EZP-31743: Multi-input single field validation doesn't show proper error #1435

merged 1 commit into from
Jul 20, 2020

Conversation

GrabowskiM
Copy link
Contributor

@GrabowskiM GrabowskiM commented Jul 17, 2020 •
edited
Loading

Question Answer
Tickets https://jira.ez.no/browse/EZP-31743
Bug fix? yes
New feature? no
BC breaks? yes
Tests pass? no
Doc needed? yes/no
License GPL-2.0

So far proof of concept

Checklist:

  • Coding standards ($ composer fix-cs)
  • Ready for Code Review

@GrabowskiM GrabowskiM requested a review from dew326 July 17, 2020 10:08
@GrabowskiM GrabowskiM changed the base branch from master to 1.5 July 17, 2020 10:08
@GrabowskiM GrabowskiM force-pushed the EZP-31743-multi-input-single-field-validation-doesnt-show-proper-error branch from edd4623 to fe80ac4 Compare July 17, 2020 10:08
@GrabowskiM GrabowskiM changed the title [WIP] EZP-31743: Multi-input single field validation doesn't show proper error EZP-31743: Multi-input single field validation doesn't show proper error Jul 17, 2020
@tomaszszopinski tomaszszopinski self-assigned this Jul 20, 2020
tomaszszopinski
tomaszszopinski approved these changes Jul 20, 2020
View reviewed changes
Copy link
Contributor

@tomaszszopinski tomaszszopinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA approved on eZPlatform 2.5-dev with diff.

@lserwatka lserwatka merged commit fb55307 into 1.5 Jul 20, 2020
@lserwatka lserwatka deleted the EZP-31743-multi-input-single-field-validation-doesnt-show-proper-error branch July 20, 2020 14:14
@GrabowskiM
Copy link
Contributor Author

Merge up done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomaszszopinski tomaszszopinski tomaszszopinski approved these changes

@dew326 dew326 dew326 approved these changes

Assignees

@tomaszszopinski tomaszszopinski

Labels
QA approved
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@GrabowskiM @dew326 @tomaszszopinski @lserwatka